Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 523052: More cleanup of slot handling in the nonoptimizing code generator.... (Closed)

Created:
10 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

More cleanup of slot handling in the nonoptimizing code generator. Rename CreateSlotOperand so that it's clear it can emit code. Use it where possible. Committed: http://code.google.com/p/v8/source/detail?r=3534

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -194 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 8 chunks +42 lines, -64 lines 0 comments Download
M src/fast-codegen.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 2 7 chunks +34 lines, -60 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 8 chunks +40 lines, -66 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 11 months ago (2010-01-05 10:48:52 UTC) #1
Lasse Reichstein
10 years, 11 months ago (2010-01-05 11:03:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698