src/fast-codegen.h - Issue 523052: More cleanup of slot handling in the nonoptimizing code generator....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/fast-codegen.h

Issue 523052: More cleanup of slot handling in the nonoptimizing code generator.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/fast-codegen.h

===================================================================

--- src/fast-codegen.h (revision 3531)

+++ src/fast-codegen.h (working copy)

@@ -219,9 +219,10 @@

void Move(Slot* dst, Register source, Register scratch1, Register scratch2);

void Move(Register dst, Slot* source);

- // Templated to allow for Operand on intel and MemOperand on ARM.

- template <typename MemoryLocation>

- MemoryLocation CreateSlotOperand(Slot* slot, Register scratch);

+ // Return an operand used to read/write to a known (ie, non-LOOKUP) slot.

+ // May emit code to traverse the context chain, destroying the scratch

+ // register.

+ MemOperand EmitSlotSearch(Slot* slot, Register scratch);

// Drop the TOS, and store source to destination.

// If destination is TOS, just overwrite TOS with source.

« no previous file with comments | « src/arm/fast-codegen-arm.cc ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »