Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/alternate_nav_url_fetcher.cc

Issue 523043: Blacklist particular TLD+1s for accidental search infobars, to avoid showing ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/alternate_nav_url_fetcher.cc
===================================================================
--- chrome/browser/alternate_nav_url_fetcher.cc (revision 35485)
+++ chrome/browser/alternate_nav_url_fetcher.cc (working copy)
@@ -13,6 +13,7 @@
#include "chrome/common/notification_service.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
+#include "net/base/registry_controlled_domain.h"
#include "net/url_request/url_request.h"
AlternateNavURLFetcher::AlternateNavURLFetcher(
@@ -86,9 +87,31 @@
(((response_code / 100) == 2) ||
(response_code == 401) || (response_code == 407))) {
state_ = SUCCEEDED;
+
+ // The following TLD+1s are used as destinations by ISPs/DNS providers/etc.
+ // who return provider-controlled pages to arbitrary user navigation
+ // attempts. Because this can result in infobars on large fractions of user
+ // searches, we don't show automatic infobars for these. Note that users
+ // can still choose to explicitly navigate to or search for pages in these
+ // domains, and can still get infobars for cases that wind up on other
+ // domains (e.g. legit intranet sites), we're just trying to avoid
+ // erroneously harassing the user with our own UI prompts.
+ const char* kBlacklistedSites[] = {
+ "comcast.com",
+ "opendns.com",
+ "verizon.net",
+ };
+ for (size_t i = 0; i < arraysize(kBlacklistedSites); ++i) {
+ if (net::RegistryControlledDomainService::SameDomainOrHost(
+ url, GURL(kBlacklistedSites[i]))) {
+ state_ = FAILED;
+ break;
+ }
+ }
} else {
state_ = FAILED;
}
+
ShowInfobarIfPossible();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698