Issue 5229001: Mark AutomationProxyTest.AppModalDialogTest as flaky. Dashboard shows 25 fail...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5229001: Mark AutomationProxyTest.AppModalDialogTest as flaky. Dashboard shows 25 fail... (Closed)

Created:
10 years, 1 month ago by kkania

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mark AutomationProxyTest.AppModalDialogTest as flaky. Dashboard shows 25 failures in past 10 days. BUG=25039 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66629

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/test/automation/automation_proxy_uitest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

10 years, 1 month ago (2010-11-18 22:45:56 UTC) #2

OK

On Thu, Nov 18, 2010 at 9:33 AM,  <kkania@chromium.org> wrote:
> Reviewers: Jay Civelli,
>
> Description:
> Mark AutomationProxyTest.AppModalDialogTest as flaky. Dashboard shows 25
> failures in past 10 days.
> BUG=25039
> TEST=none
>
> Please review this at http://codereview.chromium.org/5229001/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/automation/automation_proxy_uitest.cc
>
>
> Index: chrome/test/automation/automation_proxy_uitest.cc
> ===================================================================
> --- chrome/test/automation/automation_proxy_uitest.cc   (revision 66526)
> +++ chrome/test/automation/automation_proxy_uitest.cc   (working copy)
> @@ -1399,7 +1399,8 @@
>   EXPECT_FALSE(matches.empty());
>  }
>
> -TEST_F(AutomationProxyTest, AppModalDialogTest) {
> +// Flaky especially on Windows. See crbug.com/25039.
> +TEST_F(AutomationProxyTest, FLAKY_AppModalDialogTest) {
>   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
>   ASSERT_TRUE(browser.get());
>   scoped_refptr<TabProxy> tab(browser->GetTab(0));
>
>
>

Expand Messages | Collapse Messages