Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Side by Side Diff: chrome/test/automation/automation_proxy_uitest.cc

Issue 5229001: Mark AutomationProxyTest.AppModalDialogTest as flaky. Dashboard shows 25 fail... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "app/app_switches.h" 7 #include "app/app_switches.h"
8 #include "app/message_box_flags.h" 8 #include "app/message_box_flags.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 1381 matching lines...) Expand 10 before | Expand all | Expand 10 after
1392 EXPECT_TRUE(edit->SetText(L"Roflcopter")); 1392 EXPECT_TRUE(edit->SetText(L"Roflcopter"));
1393 EXPECT_TRUE(edit->WaitForQuery(action_max_timeout_ms())); 1393 EXPECT_TRUE(edit->WaitForQuery(action_max_timeout_ms()));
1394 bool query_in_progress; 1394 bool query_in_progress;
1395 EXPECT_TRUE(edit->IsQueryInProgress(&query_in_progress)); 1395 EXPECT_TRUE(edit->IsQueryInProgress(&query_in_progress));
1396 EXPECT_FALSE(query_in_progress); 1396 EXPECT_FALSE(query_in_progress);
1397 std::vector<AutocompleteMatchData> matches; 1397 std::vector<AutocompleteMatchData> matches;
1398 EXPECT_TRUE(edit->GetAutocompleteMatches(&matches)); 1398 EXPECT_TRUE(edit->GetAutocompleteMatches(&matches));
1399 EXPECT_FALSE(matches.empty()); 1399 EXPECT_FALSE(matches.empty());
1400 } 1400 }
1401 1401
1402 TEST_F(AutomationProxyTest, AppModalDialogTest) { 1402 // Flaky especially on Windows. See crbug.com/25039.
1403 TEST_F(AutomationProxyTest, FLAKY_AppModalDialogTest) {
1403 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); 1404 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
1404 ASSERT_TRUE(browser.get()); 1405 ASSERT_TRUE(browser.get());
1405 scoped_refptr<TabProxy> tab(browser->GetTab(0)); 1406 scoped_refptr<TabProxy> tab(browser->GetTab(0));
1406 ASSERT_TRUE(tab.get()); 1407 ASSERT_TRUE(tab.get());
1407 1408
1408 bool modal_dialog_showing = false; 1409 bool modal_dialog_showing = false;
1409 MessageBoxFlags::DialogButton button = MessageBoxFlags::DIALOGBUTTON_NONE; 1410 MessageBoxFlags::DialogButton button = MessageBoxFlags::DIALOGBUTTON_NONE;
1410 EXPECT_TRUE(automation()->GetShowingAppModalDialog(&modal_dialog_showing, 1411 EXPECT_TRUE(automation()->GetShowingAppModalDialog(&modal_dialog_showing,
1411 &button)); 1412 &button));
1412 EXPECT_FALSE(modal_dialog_showing); 1413 EXPECT_FALSE(modal_dialog_showing);
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1696 int diff_pixels_count = 0; 1697 int diff_pixels_count = 0;
1697 for (int x = 0; x < img_size.width(); ++x) { 1698 for (int x = 0; x < img_size.width(); ++x) {
1698 for (int y = 0; y < img_size.height(); ++y) { 1699 for (int y = 0; y < img_size.height(); ++y) {
1699 if (*snapshot_bmp.getAddr32(x, y) != *reference_bmp.getAddr32(x, y)) { 1700 if (*snapshot_bmp.getAddr32(x, y) != *reference_bmp.getAddr32(x, y)) {
1700 ++diff_pixels_count; 1701 ++diff_pixels_count;
1701 } 1702 }
1702 } 1703 }
1703 } 1704 }
1704 ASSERT_EQ(diff_pixels_count, 0); 1705 ASSERT_EQ(diff_pixels_count, 0);
1705 } 1706 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698