Issue 5219001: Clean var formatting in mod_for_factory

Issue 5219001: Clean var formatting in mod_for_factory (Closed)

Created:
10 years, 1 month ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te, Micah C

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Clean var formatting in mod_for_factory BUG=chrome-os-partner:1583 TEST=built factory image Change-Id: Icc15295ca3ce6113ea22a988e2e755ab513a43de

Patch Set 2 : . #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -28 lines)			Patch
M	mod_for_factory_scripts/200patchInitScript	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	mod_for_factory_scripts/300modifyDescription	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mod_for_factory_scripts/500populateQualDbs	View	1	1 chunk	+12 lines, -10 lines	2 comments	Download
M	mod_for_factory_scripts/600customizeRelease	View		1 chunk	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

LGTM with a nit http://codereview.chromium.org/5219001/diff/1/mod_for_factory_scripts/500populateQualDbs File mod_for_factory_scripts/500populateQualDbs (right): http://codereview.chromium.org/5219001/diff/1/mod_for_factory_scripts/500populateQualDbs#newcode17 mod_for_factory_scripts/500populateQualDbs:17: if [ ! -d "${KEEPDB}" ...

10 years, 1 month ago (2010-11-18 05:30:18 UTC) #2

Nick Sanders

http://codereview.chromium.org/5219001/diff/1/mod_for_factory_scripts/500populateQualDbs File mod_for_factory_scripts/500populateQualDbs (right): http://codereview.chromium.org/5219001/diff/1/mod_for_factory_scripts/500populateQualDbs#newcode17 mod_for_factory_scripts/500populateQualDbs:17: if [ ! -d "${KEEPDB}" -a \ Thanks, that ...

10 years, 1 month ago (2010-11-18 05:54:15 UTC) #3

Micah C

FYI http://codereview.chromium.org/5219001/diff/4001/mod_for_factory_scripts/500populateQualDbs File mod_for_factory_scripts/500populateQualDbs (right): http://codereview.chromium.org/5219001/diff/4001/mod_for_factory_scripts/500populateQualDbs#newcode18 mod_for_factory_scripts/500populateQualDbs:18: [ "${BOARD}" = "x86-agz" -o "{BOARD}" = "x86-mario" ...

10 years, 1 month ago (2010-11-22 19:53:54 UTC) #4

Nick Sanders

10 years, 1 month ago (2010-11-23 05:48:57 UTC) #5

Will fix.

http://codereview.chromium.org/5219001/diff/4001/mod_for_factory_scripts/500p...
File mod_for_factory_scripts/500populateQualDbs (right):

http://codereview.chromium.org/5219001/diff/4001/mod_for_factory_scripts/500p...
mod_for_factory_scripts/500populateQualDbs:18: [ "${BOARD}" = "x86-agz" -o
"{BOARD}" = "x86-mario" ]; then
Indeed it did, thanks for noticing!

Expand Messages | Collapse Messages