Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: mod_for_factory_scripts/500populateQualDbs

Issue 5219001: Clean var formatting in mod_for_factory (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git
Patch Set: . Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mod_for_factory_scripts/300modifyDescription ('k') | mod_for_factory_scripts/600customizeRelease » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mod_for_factory_scripts/500populateQualDbs
diff --git a/mod_for_factory_scripts/500populateQualDbs b/mod_for_factory_scripts/500populateQualDbs
index fff9a05642290e05285b1fb554a9cc351d828fc0..e6bbb2f0ca085cbc24dabcb6e749621f0a203091 100755
--- a/mod_for_factory_scripts/500populateQualDbs
+++ b/mod_for_factory_scripts/500populateQualDbs
@@ -6,16 +6,18 @@
TEST_DIR="${ROOT_FS_DIR}/usr/local/autotest/site_tests/hardware_Components"
-pushd ${TEST_DIR} 1> /dev/null
+if [ -d "${TEST_DIR}" ]; then
+ pushd "${TEST_DIR}" >/dev/null
-# Remove the DB directories belonging to other boards.
-KEEPDB="data_${BOARD}"
-ls -d data_* 2> /dev/null | grep -v ${KEEPDB} | xargs rm -fr
+ # Remove the DB directories belonging to other boards.
+ KEEPDB="data_${BOARD}"
+ ls -d data_* 2>/dev/null | grep -v "${KEEPDB}" | xargs rm -fr
-# Ensure there is DB directory in x86-agz and x86-mario.
-if [ ! -d ${KEEPDB} -a \
- \( "${BOARD}" = "x86-agz" -o "${BOARD}" = "x86-mario" \) ]; then
- echo "No component DB directory found at: ${KEEPDB}"
-fi
+ # Ensure there is DB directory in x86-agz and x86-mario.
+ if [ ! -d "${KEEPDB}" ] &&
+ [ "${BOARD}" = "x86-agz" -o "{BOARD}" = "x86-mario" ]; then
Micah C 2010/11/22 19:53:55 drive-by comment: looks like ${BOARD} got inadvert
Nick Sanders 2010/11/23 05:48:57 Indeed it did, thanks for noticing!
+ echo "No component DB directory found at: ${KEEPDB}"
+ fi
-popd 1> /dev/null
+ popd >/dev/null
+fi
« no previous file with comments | « mod_for_factory_scripts/300modifyDescription ('k') | mod_for_factory_scripts/600customizeRelease » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698