Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 5216002: Merge 66630 - Fix SPDY crash on race when canceling a stream that just got cr... (Closed)

Created:
10 years, 1 month ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 66630 - Fix SPDY crash on race when canceling a stream that just got created. When I fixed the code not to be re-entrant (since that caused crashes) in r61880, I created a window when the pending create callback was posted to the MessageLoop to be run on the next iteration. In this window before it actually gets invoked, if the pending stream creation got cancelled, then the callback wasn't cancelled, so we would execute a callback on a cancelled stream creation, which can cause crashes. The fix is to keep track of the pending callbacks. Cancellation of pending stream creations check this pending callback map first. BUG=63532 TEST=See bug thread for repro steps. New unit test added as well. Review URL: http://codereview.chromium.org/5174005 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -5 lines) Patch
M net/spdy/spdy_session.h View 3 chunks +18 lines, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 4 chunks +24 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
10 years, 1 month ago (2010-11-18 18:30:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698