Issue 5174005: Fix SPDY crash on race when canceling a stream that just got created.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5174005: Fix SPDY crash on race when canceling a stream that just got created. (Closed)

Created:
10 years, 1 month ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix SPDY crash on race when canceling a stream that just got created. When I fixed the code not to be re-entrant (since that caused crashes) in r61880, I created a window when the pending create callback was posted to the MessageLoop to be run on the next iteration. In this window before it actually gets invoked, if the pending stream creation got cancelled, then the callback wasn't cancelled, so we would execute a callback on a cancelled stream creation, which can cause crashes. The fix is to keep track of the pending callbacks. Cancellation of pending stream creations check this pending callback map first. BUG=63532 TEST=See bug thread for repro steps. New unit test added as well. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66630

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -5 lines)			Patch
M	net/spdy/spdy_session.h	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	net/spdy/spdy_session.cc	View	4 chunks	+24 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View	1 chunk	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages