Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2183)

Unified Diff: base/values.cc

Issue 5213002: Fix for Bug 50726 "Save extension list and "winning" prefs from extensions" (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Temporary hack to fix regression in unit tests Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/values.cc
diff --git a/base/values.cc b/base/values.cc
index cd0f6a81eef3737fde57fbbb9a022494fe80c94a..c6a377f63f0c386e3cca0dffcd9d8be26143d4e5 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -133,6 +133,13 @@ bool Value::Equals(const Value* other) const {
return other->IsType(TYPE_NULL);
}
+// static
+bool Value::Equals(const Value* a, const Value* b) {
Aaron Boodman 2010/11/23 20:35:13 Needs a unit test.
battre (please use the other) 2010/11/30 17:46:53 Done.
+ if ((a == NULL) && (b == NULL)) return true;
+ if ((a == NULL) ^ (b == NULL)) return false;
+ return a->Equals(b);
+}
+
Value::Value(ValueType type) : type_(type) {
}

Powered by Google App Engine
This is Rietveld 408576698