Fix for Bug 50726 "Save extension list and "winning" prefs from extensions"

base/values.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 
@@ skipping 115 matching lines @@
   return CreateNullValue();
 }
 
 bool Value::Equals(const Value* other) const {
   // This method should only be getting called for null Values--all subclasses
   // need to provide their own implementation;.
   DCHECK(IsType(TYPE_NULL));
   return other->IsType(TYPE_NULL);
 }
 
+// static
+bool Value::Equals(const Value* a, const Value* b) {

[Aaron Boodman, 2010/11/23 20:35:13]

Needs a unit test.

[battre (please use the other), 2010/11/30 17:46:53]

Done.

+  if ((a == NULL) && (b == NULL)) return true;
+  if ((a == NULL) ^  (b == NULL)) return false;
+  return a->Equals(b);
+}
+
 Value::Value(ValueType type) : type_(type) {
 }
 
 ///////////////////// FundamentalValue ////////////////////
 
 FundamentalValue::FundamentalValue(bool in_value)
     : Value(TYPE_BOOLEAN), boolean_value_(in_value) {
 }
 
 FundamentalValue::FundamentalValue(int in_value)
@@ skipping 831 matching lines @@
       return false;
   }
   if (lhs_it != end() || rhs_it != other_list->end())
     return false;
 
   return true;
 }
 
 ValueSerializer::~ValueSerializer() {
 }