Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 521012: Update gmock and gtest. (Closed)

Created:
10 years, 12 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Update gmock and gtest. (Hoping to pick up a clang-related bug fix.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35352

Patch Set 1 #

Patch Set 2 : update readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1368 lines, -742 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/README.chromium View 1 2 chunks +4 lines, -8 lines 0 comments Download
M testing/gmock/CONTRIBUTORS View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gmock/Makefile.am View 4 chunks +44 lines, -136 lines 0 comments Download
M testing/gmock/include/gmock/gmock-actions.h View 21 chunks +83 lines, -5 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-actions.h View 23 chunks +64 lines, -0 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-actions.h.pump View 5 chunks +24 lines, -0 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-function-mockers.h View 14 chunks +111 lines, -15 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-function-mockers.h.pump View 3 chunks +10 lines, -5 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h View 35 chunks +70 lines, -1 line 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h.pump View 6 chunks +12 lines, -1 line 0 comments Download
M testing/gmock/include/gmock/gmock-generated-nice-strict.h View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-nice-strict.h.pump View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/gmock/include/gmock/gmock-matchers.h View 46 chunks +112 lines, -11 lines 0 comments Download
M testing/gmock/include/gmock/gmock-more-actions.h View 4 chunks +20 lines, -0 lines 0 comments Download
M testing/gmock/include/gmock/gmock-printers.h View 3 chunks +59 lines, -56 lines 0 comments Download
M testing/gmock/include/gmock/gmock-spec-builders.h View 25 chunks +58 lines, -25 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-internal-utils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-port.h View 3 chunks +13 lines, -19 lines 0 comments Download
M testing/gmock/msvc/gmock.sln View 2 chunks +0 lines, -6 lines 0 comments Download
A testing/gmock/msvc/gmock-spec-builders_test.vcproj View 0 chunks +-1 lines, --1 lines 0 comments Download
D testing/gmock/msvc/gmock_output_test_.vcproj View 1 chunk +0 lines, -199 lines 0 comments Download
A testing/gmock/scripts/fuse_gmock_files.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/ast.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/gmock_class.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/gmock_class_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/keywords.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/tokenize.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/utils.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/generator/gmock_gen.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/gmock-config.in View 0 chunks +-1 lines, --1 lines 0 comments Download
M testing/gmock/scripts/gmock_doctor.py View 6 chunks +27 lines, -15 lines 0 comments Download
A testing/gmock/scripts/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing/gmock/scripts/upload_gmock.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M testing/gmock/src/gmock-all.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/gmock/src/gmock-internal-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/src/gmock-matchers.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M testing/gmock/src/gmock-printers.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M testing/gmock/src/gmock-spec-builders.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M testing/gmock/test/gmock-actions_test.cc View 10 chunks +61 lines, -15 lines 0 comments Download
M testing/gmock/test/gmock-cardinalities_test.cc View 2 chunks +7 lines, -1 line 0 comments Download
M testing/gmock/test/gmock-generated-actions_test.cc View 12 chunks +31 lines, -13 lines 0 comments Download
M testing/gmock/test/gmock-generated-function-mockers_test.cc View 7 chunks +30 lines, -0 lines 0 comments Download
M testing/gmock/test/gmock-generated-matchers_test.cc View 8 chunks +16 lines, -7 lines 0 comments Download
M testing/gmock/test/gmock-internal-utils_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M testing/gmock/test/gmock-matchers_test.cc View 14 chunks +78 lines, -9 lines 0 comments Download
M testing/gmock/test/gmock-more-actions_test.cc View 6 chunks +12 lines, -8 lines 0 comments Download
M testing/gmock/test/gmock-nice-strict_test.cc View 5 chunks +19 lines, -8 lines 0 comments Download
M testing/gmock/test/gmock-port_test.cc View 1 chunk +126 lines, -1 line 0 comments Download
M testing/gmock/test/gmock-printers_test.cc View 10 chunks +21 lines, -12 lines 0 comments Download
M testing/gmock/test/gmock-spec-builders_test.cc View 13 chunks +79 lines, -35 lines 0 comments Download
M testing/gmock/test/gmock_leak_test.py View 1 chunk +30 lines, -24 lines 0 comments Download
M testing/gmock/test/gmock_leak_test_.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/gmock/test/gmock_link_test.h View 5 chunks +20 lines, -1 line 0 comments Download
M testing/gmock/test/gmock_output_test.py View 3 chunks +10 lines, -60 lines 0 comments Download
M testing/gmock/test/gmock_output_test_.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M testing/gmock/test/gmock_output_test_golden.txt View 15 chunks +29 lines, -21 lines 0 comments Download
M testing/gmock/test/gmock_test_utils.py View 3 chunks +45 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
(running through trybots)
10 years, 12 months ago (2009-12-29 21:13:26 UTC) #1
awong
LGTM assuming try bots pass. As a sanity check, no files should be deleted right?
10 years, 12 months ago (2009-12-29 21:35:40 UTC) #2
Evan Martin
On 2009/12/29 21:35:40, awong wrote: > LGTM assuming try bots pass. > > As a ...
10 years, 12 months ago (2009-12-29 21:39:37 UTC) #3
awong
10 years, 12 months ago (2009-12-29 21:42:13 UTC) #4 
Ah, missed the "D" when skimming the list.

LGTM++


On Tue, Dec 29, 2009 at 1:39 PM, <evan@chromium.org> wrote:

> On 2009/12/29 21:35:40, awong wrote:
>
>> LGTM assuming try bots pass.
>>
>
>  As a sanity check, no files should be deleted right?
>>
>
> seems the one deleted file was
> http://code.google.com/p/googlemock/source/detail?r=247
>
>
>
> http://codereview.chromium.org/521012
>

Powered by Google App Engine
This is Rietveld 408576698