Issue 5208001: Fix a bug where installing an extension in incognito would not show the help

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5208001: Fix a bug where installing an extension in incognito would not show the help (Closed)

Created:
10 years, 1 month ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix a bug where installing an extension in incognito would not show the help bubble. BUG=62541 TEST=see bug for repro Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66656

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove check #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	chrome/browser/extensions/extension_install_ui.cc	View	1	3 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

lgtm, although it would be nice if we had tests that could catch subsequent regressions ...

10 years, 1 month ago (2010-11-18 01:25:44 UTC) #2

Matt Perry

10 years, 1 month ago (2010-11-18 01:35:00 UTC) #3

http://codereview.chromium.org/5208001/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/5208001/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_install_ui.cc:162: if
((extension->browser_action() && !browser->profile()->IsOffTheRecord()) ||
On 2010/11/18 01:25:44, Antony Sargent wrote:
> Do you need to remove the IsOffTheRecord check here and modify the command
just
> above?

Thanks for reminding me. Done.

Expand Messages | Collapse Messages