Fix a bug where installing an extension in incognito would not show the help

chrome/browser/extensions/extension_install_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 
 #include <map>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 110 matching lines @@
   ShowConfirmation(UNINSTALL_PROMPT);
 }
 
 void ExtensionInstallUI::OnInstallSuccess(const Extension* extension) {
   if (extension->is_theme()) {
     ShowThemeInfoBar(previous_theme_id_, previous_use_system_theme_,
                      extension, profile_);
     return;
   }
 
-  // GetLastActiveWithProfile will fail on the build bots. This needs to be
-  // implemented differently if any test is created which depends on
-  // ExtensionInstalledBubble showing.
-  Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
+  // Note that browser actions don't appear in incognito mode initially,
+  // so be sure to use a normal browser window.
+  Profile* profile = profile_;
+  if (extension->browser_action())
+    profile = profile->GetOriginalProfile();
+  Browser* browser = Browser::GetOrCreateTabbedBrowser(profile);
+  if (browser->tab_count() == 0)
+    browser->AddBlankTab(true);
+  browser->window()->Show();
 
   if (extension->GetFullLaunchURL().is_valid()) {
     std::string hash_params = "app-id=";
     hash_params += extension->id();
 
     std::string url(chrome::kChromeUINewTabURL);
     url += "/#";
     url += hash_params;
     browser->AddSelectedTabWithURL(GURL(url), PageTransition::TYPED);
 
     return;
   }
 
 #if defined(TOOLKIT_VIEWS)
   if (!browser)
     return;
 
   ExtensionInstalledBubble::Show(extension, browser, icon_);
 #elif defined(OS_MACOSX)
   DCHECK(browser);
   // Note that browser actions don't appear in incognito mode initially,
   // so fall back to the generic case.
   if ((extension->browser_action() && !browser->profile()->IsOffTheRecord()) ||

[asargent_no_longer_on_chrome, 2010/11/18 01:25:44]

Do you need to remove the IsOffTheRecord check here and modify the command just
above?

[Matt Perry, 2010/11/18 01:35:00]

Thanks for reminding me. Done.

       !extension->omnibox_keyword().empty() ||
       (extension->page_action() &&
       !extension->page_action()->default_icon_path().empty())) {
     ExtensionInstalledBubbleCocoa::ShowExtensionInstalledBubble(
         browser->window()->GetNativeHandle(),
         extension, browser, icon_);
   }  else {
     // If the extension is of type GENERIC, meaning it doesn't have a UI
     // surface to display for this window, launch infobar instead of popup
     // bubble, because we have no guaranteed wrench menu button to point to.
@@ skipping 140 matching lines @@
     TabContents* tab_contents, const Extension* new_theme,
     const std::string& previous_theme_id, bool previous_use_system_theme) {
 #if defined(TOOLKIT_GTK)
   return new GtkThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id, previous_use_system_theme);
 #else
   return new ThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id);
 #endif
 }