net/base/keygen_handler_unittest.cc - Issue 5206005: Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/keygen_handler_unittest.cc

Issue 5206005: Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/keygen_handler_unittest.cc

===================================================================

--- net/base/keygen_handler_unittest.cc (revision 66790)

+++ net/base/keygen_handler_unittest.cc (working copy)

@@ -16,7 +16,6 @@

#include "base/logging.h"

#include "base/nss_util.h"

#include "base/task.h"

-#include "base/thread_restrictions.h"

#include "base/waitable_event.h"

#include "base/worker_pool.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -91,9 +90,6 @@

}

virtual void Run() {

- // We allow Singleton use on the worker thread here since we use a

- // WaitableEvent to synchronize, so it's safe.

- base::ThreadRestrictions::ScopedAllowSingleton scoped_allow_singleton;

KeygenHandler handler(768, "some challenge",

GURL("http://www.example.com"));

handler.set_stores_key(false); // Don't leave the key-pair behind.

« no previous file with comments | « net/base/ev_root_ca_metadata.cc ('k') | net/base/x509_certificate.h » ('j') | no next file with comments »