Issue 5204006: Renamed DefaultPrefStore into InMemoryPrefStore because it can be used in further contexts.

Issue 5204006: Renamed DefaultPrefStore into InMemoryPrefStore because it can be used in further contexts. (Closed)

Created:
10 years, 1 month ago by battre (please use the other)

Modified:
9 years, 7 months ago

Reviewers:
Pam (message me for reviews), Mattias Nissler (ping if slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Renamed DefaultPrefStore into InMemoryPrefStore because it can be used in further contexts. contributed by battre@google.com BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68350

Patch Set 3 : Rebased #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -39 lines)			Patch
M	chrome/browser/extensions/extension_pref_store_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/prefs/default_pref_store.cc	View		1 chunk	+0 lines, -21 lines	0 comments	Download
A +	chrome/browser/prefs/in_memory_pref_store.h	View		2 chunks	+10 lines, -9 lines	0 comments	Download
A	chrome/browser/prefs/in_memory_pref_store.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_notifier_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prefs/pref_service_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_value_store.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM (with a minor comment). http://codereview.chromium.org/5204006/diff/1/chrome/browser/prefs/in_memory_pref_store.h File chrome/browser/prefs/in_memory_pref_store.h (right): http://codereview.chromium.org/5204006/diff/1/chrome/browser/prefs/in_memory_pref_store.h#newcode14 chrome/browser/prefs/in_memory_pref_store.h:14: // e.g., for default ...

10 years, 1 month ago (2010-11-19 16:07:16 UTC) #2

Pam (message me for reviews)

10 years, 1 month ago (2010-11-21 18:01:14 UTC) #3

http://codereview.chromium.org/5204006/diff/1/chrome/browser/prefs/in_memory_...
File chrome/browser/prefs/in_memory_pref_store.h (right):

http://codereview.chromium.org/5204006/diff/1/chrome/browser/prefs/in_memory_...
chrome/browser/prefs/in_memory_pref_store.h:14: // e.g., for default preference
values set when a preference is registered with
On 2010/11/19 16:07:16, Mattias Nissler wrote:
> I feel there are too many commas in this sentence, but I'm not a native
speaker,
> so I leave it to you to decide :)

Looks OK to me. There's no hard rule for commas around "e.g.", except that 0 or
2 is better than 1 (unless you want to change the meaning of the sentence).

Expand Messages | Collapse Messages