Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: chrome/browser/prefs/in_memory_pref_store.h

Issue 5204006: Renamed DefaultPrefStore into InMemoryPrefStore because it can be used in further contexts. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_DEFAULT_PREF_STORE_H_ 5 #ifndef CHROME_BROWSER_PREFS_IN_MEMORY_PREF_STORE_H_
6 #define CHROME_BROWSER_PREFS_DEFAULT_PREF_STORE_H_ 6 #define CHROME_BROWSER_PREFS_IN_MEMORY_PREF_STORE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/scoped_ptr.h" 10 #include "base/scoped_ptr.h"
11 #include "chrome/common/pref_store.h" 11 #include "chrome/common/pref_store.h"
12 12
13 // This PrefStore keeps track of default preference values set when a 13 // This PrefStore keeps track of preference values in memory and can be used,
14 // preference is registered with the PrefService. 14 // e.g., for default preference values set when a preference is registered with
Mattias Nissler (ping if slow) 2010/11/19 16:07:16 I feel there are too many commas in this sentence,
Pam (message me for reviews) 2010/11/21 18:01:14 Looks OK to me. There's no hard rule for commas ar
15 class DefaultPrefStore : public PrefStore { 15 // the PrefService.
16 class InMemoryPrefStore : public PrefStore {
16 public: 17 public:
17 DefaultPrefStore(); 18 InMemoryPrefStore();
18 virtual ~DefaultPrefStore(); 19 virtual ~InMemoryPrefStore();
19 20
20 // PrefStore methods: 21 // PrefStore methods:
21 virtual DictionaryValue* prefs() const; 22 virtual DictionaryValue* prefs() const;
22 virtual PrefStore::PrefReadError ReadPrefs(); 23 virtual PrefStore::PrefReadError ReadPrefs();
23 24
24 private: 25 private:
25 // The default preference values. 26 // The default preference values.
26 scoped_ptr<DictionaryValue> prefs_; 27 scoped_ptr<DictionaryValue> prefs_;
27 28
28 DISALLOW_COPY_AND_ASSIGN(DefaultPrefStore); 29 DISALLOW_COPY_AND_ASSIGN(InMemoryPrefStore);
29 }; 30 };
30 31
31 #endif // CHROME_BROWSER_PREFS_DEFAULT_PREF_STORE_H_ 32 #endif // CHROME_BROWSER_PREFS_IN_MEMORY_PREF_STORE_H_
OLDNEW
« no previous file with comments | « chrome/browser/prefs/default_pref_store.cc ('k') | chrome/browser/prefs/in_memory_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698