Issue 519052: Add the Chrome Frame tests to the chromium_builder target in all.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 519052: Add the Chrome Frame tests to the chromium_builder target in all.gyp. (Closed)

Created:
10 years, 11 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add the Chrome Frame tests to the chromium_builder target in all.gyp. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35624

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

10 years, 11 months ago (2010-01-05 22:23:40 UTC) #2

LGTM

On Tue, Jan 5, 2010 at 1:56 PM, <robertshield@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Add the Chrome Frame tests to the chromium_builder target in all.gyp.
>
> BUG=None
> TEST=None
>
> Please review this at http://codereview.chromium.org/519052
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     build/all.gyp
>
>
> Index: build/all.gyp
> ===================================================================
> --- build/all.gyp       (revision 35548)
> +++ build/all.gyp       (working copy)
> @@ -218,6 +218,9 @@
>             # 2) be expressed in the ui tests dependencies.
>             '../webkit/tools/test_shell/test_shell.gyp:test_shell_common',
>             'temp_gyp/googleurl.gyp:googleurl_unittests',
> +            '../chrome_frame/chrome_frame.gyp:chrome_frame_tests',
> +            '../chrome_frame/chrome_frame.gyp:chrome_frame_unittests',
> +            '../chrome_frame/chrome_frame.gyp:chrome_frame_net_tests',
>           ],
>         },
>         {
>
>
>

Expand Messages | Collapse Messages