Issue 5183004: crosh: Disable connection escape sequence in ssh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5183004: crosh: Disable connection escape sequence in ssh. (Closed)

Created:
10 years, 1 month ago by rginda

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Greg Spencer (Chromium), Daniel Erat

Base URL:
http://git.chromium.org/git/window_manager.git@master

Visibility:
Public.

Description

crosh: Disable connection escape sequence in ssh. Change-Id: I4290523f94a9a1c8cf8664156b06d1d8a703db42 BUG=chromium-os:9359 TEST=gmerge onto device and ensure that escape code no longer works Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=87c4518

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bin/crosh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 1 month ago (2010-11-18 19:45:55 UTC) #2

LGTM for security, although it's a pity we have to disable ~. (close
connection).  Short of changing SSH, I don't see any other way.

On Thu, Nov 18, 2010 at 11:25 AM,  <rginda@chromium.org> wrote:
> Reviewers: Luigi Semenzato,
>
> Description:
> crosh: Disable connection escape sequence in ssh.
>
> Change-Id: I4290523f94a9a1c8cf8664156b06d1d8a703db42
>
> BUG=chromium-os:8032
> TEST=gmerge onto device and ensure that escape code no longer works
>
> Please review this at http://codereview.chromium.org/5183004/
>
> SVN Base: http://git.chromium.org/git/window_manager.git@master
>
> Affected files:
>  M bin/crosh
>
>
> Index: bin/crosh
> diff --git a/bin/crosh b/bin/crosh
> index
>
36c92d14fd7cdd5f734cd544f50902f31e4acc13..f990d3d8e5119d8ec7595fdd3200c7a2d48fc345
> 100755
> --- a/bin/crosh
> +++ b/bin/crosh
> @@ -186,7 +186,7 @@ cmd_ssh() {
>   fi
>
>   echo "open: host: $host, user: $user, port: $port"
> -  ssh -F /etc/ssh/ssh_config -p "$port" "$user@$host"
> +  ssh -e none -F /etc/ssh/ssh_config -p "$port" "$user@$host"
>  }
>
>  cmd_ssh_forget_host() {
>
>
>

Expand Messages | Collapse Messages