chrome/browser/notifications/balloon_host.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon_host.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renaming PROCESS_END_* to EXIT_CODE_* Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/browser/notifications/balloon_host.h ('k') | chrome/browser/profile_import_process_host.h » ('j') | chrome/browser/tab_contents/tab_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/balloon_host.cc

diff --git a/chrome/browser/notifications/balloon_host.cc b/chrome/browser/notifications/balloon_host.cc

index 5fe8c4e9f4fafa84054687494ce9578c5c48e540..3fb3a6bc17d02179f4178428724c613d7f3e91de 100644

--- a/chrome/browser/notifications/balloon_host.cc

+++ b/chrome/browser/notifications/balloon_host.cc

@@ -91,7 +91,8 @@ const string16& BalloonHost::GetSource() const {

WebPreferences BalloonHost::GetWebkitPrefs() {

WebPreferences web_prefs =

- RenderViewHostDelegateHelper::GetWebkitPrefs(GetProfile(), enable_dom_ui_);

+ RenderViewHostDelegateHelper::GetWebkitPrefs(GetProfile(),

+ enable_dom_ui_);

web_prefs.allow_scripts_to_close_windows = true;

return web_prefs;

}

@@ -130,7 +131,9 @@ void BalloonHost::RenderViewReady(RenderViewHost* render_view_host) {

Source<BalloonHost>(this), NotificationService::NoDetails());

}

-void BalloonHost::RenderViewGone(RenderViewHost* render_view_host) {

+void BalloonHost::RenderViewGone(RenderViewHost* render_view_host,

+ base::TerminationStatus status,

+ int error_code) {

Close(render_view_host);

}