chrome/browser/metrics/metrics_service.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renaming PROCESS_END_* to EXIT_CODE_* Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc ('k') | chrome/browser/nacl_host/nacl_process_host.h » ('j') | chrome/browser/tab_contents/tab_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index 9cafefc649893462d21730c3b1ea763f8197955e..cfda7f0d51928fd55e639a143dfe9d9c5e5165fc 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -606,11 +606,13 @@ void MetricsService::Observe(NotificationType type,

LogLoadStarted();

break;

- case NotificationType::RENDERER_PROCESS_CLOSED:

- {

+ case NotificationType::RENDERER_PROCESS_CLOSED: {

RenderProcessHost::RendererClosedDetails* process_details =

Details<RenderProcessHost::RendererClosedDetails>(details).ptr();

- if (process_details->did_crash) {

+ if (process_details->status ==

+ base::TERMINATION_STATUS_PROCESS_CRASHED ||

+ process_details->status ==

+ base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {

Greg Spencer (Chromium) 2010/12/03 01:00:07 I'm wondering if I should be adding logging here f

if (process_details->was_extension_renderer) {

LogExtensionRendererCrash();

} else {