chrome/browser/nacl_host/nacl_process_host.cc - Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 5172009: This adds some plumbing for propagating the reason for a renderer's death (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renaming PROCESS_END_* to EXIT_CODE_* Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/browser/nacl_host/nacl_process_host.h ('k') | chrome/browser/notifications/balloon_host.h » ('j') | chrome/browser/tab_contents/tab_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/nacl_host/nacl_process_host.cc

diff --git a/chrome/browser/nacl_host/nacl_process_host.cc b/chrome/browser/nacl_host/nacl_process_host.cc

index 82008925db55096124e737cbc1672a310b6e4a1b..666db1ce661c1b7f998ddd21d61fc1a860b261d0 100644

--- a/chrome/browser/nacl_host/nacl_process_host.cc

+++ b/chrome/browser/nacl_host/nacl_process_host.cc

@@ -163,10 +163,11 @@ void NaClProcessHost::OnProcessLaunchedByBroker(base::ProcessHandle handle) {

OnProcessLaunched();

}

-bool NaClProcessHost::DidChildCrash() {

+base::TerminationStatus NaClProcessHost::GetChildTerminationStatus(

+ int* exit_code) {

if (running_on_wow64_)

- return base::DidProcessCrash(NULL, handle());

- return BrowserChildProcessHost::DidChildCrash();

+ return base::GetTerminationStatus(handle(), exit_code);

+ return BrowserChildProcessHost::GetChildTerminationStatus(exit_code);

}

void NaClProcessHost::OnChildDied() {