Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: tests/trychange_unittest.py

Issue 517068: Fix unit tests (mostly esthetical) (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/trychange_unittest.py
diff --git a/tests/trychange_unittest.py b/tests/trychange_unittest.py
index dbaa763b23284a1966a4f9f1cc43dbeec6a06972..fdccf8ab65554d71d24f59bacabd7abbe9bb0de7 100644
--- a/tests/trychange_unittest.py
+++ b/tests/trychange_unittest.py
@@ -42,7 +42,7 @@ class TryChangeUnittest(TryChangeTestsBase):
'EscapeDot', 'GIT', 'GuessVCS',
'HELP_STRING', 'InvalidScript', 'NoTryServerAccess', 'PrintSuccess',
'SCM', 'SVN', 'TryChange', 'USAGE',
- 'breakpad', 'datetime', 'gclient_utils', 'getpass', 'logging',
+ 'breakpad', 'datetime', 'errno', 'gclient_utils', 'getpass', 'logging',
'optparse', 'os', 'posixpath', 'scm', 'shutil', 'sys', 'tempfile',
'urllib',
]
@@ -56,7 +56,7 @@ class SVNUnittest(TryChangeTestsBase):
members = [
'AutomagicalSettings', 'GclStyleSettings', 'GclientStyleSettings',
'GetCodeReviewSetting', 'ReadRootFile',
- 'GenerateDiff', 'GetFileNames', 'GetLocalRoot',
+ 'GenerateDiff', 'GetFileNames',
]
# If this test fails, you should add the relevant test.
self.compareMembers(trychange.SVN, members)
@@ -71,7 +71,7 @@ class SVNUnittest(TryChangeTestsBase):
self.mox.ReplayAll()
svn = trychange.SVN(self.options, self.fake_root)
self.assertEqual(svn.GetFileNames(), self.expected_files)
- self.assertEqual(svn.GetLocalRoot(), self.fake_root)
+ self.assertEqual(svn.checkout_root, self.fake_root)
self.assertEqual(svn.GenerateDiff(), 'A diff')
@@ -81,7 +81,7 @@ class GITUnittest(TryChangeTestsBase):
members = [
'AutomagicalSettings', 'GclStyleSettings', 'GclientStyleSettings',
'GetCodeReviewSetting', 'ReadRootFile',
- 'GenerateDiff', 'GetFileNames', 'GetLocalRoot',
+ 'GenerateDiff', 'GetFileNames',
]
# If this test fails, you should add the relevant test.
self.compareMembers(trychange.GIT, members)
@@ -96,7 +96,7 @@ class GITUnittest(TryChangeTestsBase):
self.mox.ReplayAll()
git = trychange.GIT(self.options, self.fake_root)
self.assertEqual(git.GetFileNames(), self.expected_files)
- self.assertEqual(git.GetLocalRoot(), self.fake_root)
+ self.assertEqual(git.checkout_root, self.fake_root)
self.assertEqual(git.GenerateDiff(), 'A diff')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698