Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: tests/trychange_unittest.py

Issue 517068: Fix unit tests (mostly esthetical) (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for trychange.py.""" 6 """Unit tests for trychange.py."""
7 7
8 import optparse 8 import optparse
9 9
10 # Local imports 10 # Local imports
(...skipping 24 matching lines...) Expand all
35 self.options.email = None 35 self.options.email = None
36 36
37 37
38 class TryChangeUnittest(TryChangeTestsBase): 38 class TryChangeUnittest(TryChangeTestsBase):
39 """General trychange.py tests.""" 39 """General trychange.py tests."""
40 def testMembersChanged(self): 40 def testMembersChanged(self):
41 members = [ 41 members = [
42 'EscapeDot', 'GIT', 'GuessVCS', 42 'EscapeDot', 'GIT', 'GuessVCS',
43 'HELP_STRING', 'InvalidScript', 'NoTryServerAccess', 'PrintSuccess', 43 'HELP_STRING', 'InvalidScript', 'NoTryServerAccess', 'PrintSuccess',
44 'SCM', 'SVN', 'TryChange', 'USAGE', 44 'SCM', 'SVN', 'TryChange', 'USAGE',
45 'breakpad', 'datetime', 'gclient_utils', 'getpass', 'logging', 45 'breakpad', 'datetime', 'errno', 'gclient_utils', 'getpass', 'logging',
46 'optparse', 'os', 'posixpath', 'scm', 'shutil', 'sys', 'tempfile', 46 'optparse', 'os', 'posixpath', 'scm', 'shutil', 'sys', 'tempfile',
47 'urllib', 47 'urllib',
48 ] 48 ]
49 # If this test fails, you should add the relevant test. 49 # If this test fails, you should add the relevant test.
50 self.compareMembers(trychange, members) 50 self.compareMembers(trychange, members)
51 51
52 52
53 class SVNUnittest(TryChangeTestsBase): 53 class SVNUnittest(TryChangeTestsBase):
54 """trychange.SVN tests.""" 54 """trychange.SVN tests."""
55 def testMembersChanged(self): 55 def testMembersChanged(self):
56 members = [ 56 members = [
57 'AutomagicalSettings', 'GclStyleSettings', 'GclientStyleSettings', 57 'AutomagicalSettings', 'GclStyleSettings', 'GclientStyleSettings',
58 'GetCodeReviewSetting', 'ReadRootFile', 58 'GetCodeReviewSetting', 'ReadRootFile',
59 'GenerateDiff', 'GetFileNames', 'GetLocalRoot', 59 'GenerateDiff', 'GetFileNames',
60 ] 60 ]
61 # If this test fails, you should add the relevant test. 61 # If this test fails, you should add the relevant test.
62 self.compareMembers(trychange.SVN, members) 62 self.compareMembers(trychange.SVN, members)
63 63
64 def testBasic(self): 64 def testBasic(self):
65 trychange.scm.SVN.GetCheckoutRoot(self.fake_root).AndReturn(self.fake_root) 65 trychange.scm.SVN.GetCheckoutRoot(self.fake_root).AndReturn(self.fake_root)
66 trychange.scm.SVN.GenerateDiff(['foo.txt', 'bar.txt'], 66 trychange.scm.SVN.GenerateDiff(['foo.txt', 'bar.txt'],
67 self.fake_root, 67 self.fake_root,
68 full_move=True, 68 full_move=True,
69 revision=None).AndReturn('A diff') 69 revision=None).AndReturn('A diff')
70 trychange.scm.SVN.GetEmail(self.fake_root).AndReturn('georges@example.com') 70 trychange.scm.SVN.GetEmail(self.fake_root).AndReturn('georges@example.com')
71 self.mox.ReplayAll() 71 self.mox.ReplayAll()
72 svn = trychange.SVN(self.options, self.fake_root) 72 svn = trychange.SVN(self.options, self.fake_root)
73 self.assertEqual(svn.GetFileNames(), self.expected_files) 73 self.assertEqual(svn.GetFileNames(), self.expected_files)
74 self.assertEqual(svn.GetLocalRoot(), self.fake_root) 74 self.assertEqual(svn.checkout_root, self.fake_root)
75 self.assertEqual(svn.GenerateDiff(), 'A diff') 75 self.assertEqual(svn.GenerateDiff(), 'A diff')
76 76
77 77
78 class GITUnittest(TryChangeTestsBase): 78 class GITUnittest(TryChangeTestsBase):
79 """trychange.GIT tests.""" 79 """trychange.GIT tests."""
80 def testMembersChanged(self): 80 def testMembersChanged(self):
81 members = [ 81 members = [
82 'AutomagicalSettings', 'GclStyleSettings', 'GclientStyleSettings', 82 'AutomagicalSettings', 'GclStyleSettings', 'GclientStyleSettings',
83 'GetCodeReviewSetting', 'ReadRootFile', 83 'GetCodeReviewSetting', 'ReadRootFile',
84 'GenerateDiff', 'GetFileNames', 'GetLocalRoot', 84 'GenerateDiff', 'GetFileNames',
85 ] 85 ]
86 # If this test fails, you should add the relevant test. 86 # If this test fails, you should add the relevant test.
87 self.compareMembers(trychange.GIT, members) 87 self.compareMembers(trychange.GIT, members)
88 88
89 def testBasic(self): 89 def testBasic(self):
90 trychange.scm.GIT.GetCheckoutRoot(self.fake_root).AndReturn(self.fake_root) 90 trychange.scm.GIT.GetCheckoutRoot(self.fake_root).AndReturn(self.fake_root)
91 trychange.scm.GIT.GenerateDiff(self.fake_root, 91 trychange.scm.GIT.GenerateDiff(self.fake_root,
92 full_move=True, 92 full_move=True,
93 branch=None).AndReturn('A diff') 93 branch=None).AndReturn('A diff')
94 trychange.scm.GIT.GetPatchName(self.fake_root).AndReturn('bleh-1233') 94 trychange.scm.GIT.GetPatchName(self.fake_root).AndReturn('bleh-1233')
95 trychange.scm.GIT.GetEmail(self.fake_root).AndReturn('georges@example.com') 95 trychange.scm.GIT.GetEmail(self.fake_root).AndReturn('georges@example.com')
96 self.mox.ReplayAll() 96 self.mox.ReplayAll()
97 git = trychange.GIT(self.options, self.fake_root) 97 git = trychange.GIT(self.options, self.fake_root)
98 self.assertEqual(git.GetFileNames(), self.expected_files) 98 self.assertEqual(git.GetFileNames(), self.expected_files)
99 self.assertEqual(git.GetLocalRoot(), self.fake_root) 99 self.assertEqual(git.checkout_root, self.fake_root)
100 self.assertEqual(git.GenerateDiff(), 'A diff') 100 self.assertEqual(git.GenerateDiff(), 'A diff')
101 101
102 102
103 if __name__ == '__main__': 103 if __name__ == '__main__':
104 import unittest 104 import unittest
105 unittest.main() 105 unittest.main()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698