Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: gcl.py

Issue 517005: After much refactory, finally add significant functionalities to trychanges.py (Closed)
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | gclient_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 34b97d7b2c0591636f14a1ff4120058c058c20d6..63f3d52591f07d649ad45150666cab3a09426d4e 100755
--- a/gcl.py
+++ b/gcl.py
@@ -820,23 +820,6 @@ def TryChange(change_info, args, swallow_exception):
ErrorExit("You need to install trychange.py to use the try server.")
trychange_args = []
- settings = {
- 'port': GetCodeReviewSetting('TRYSERVER_HTTP_PORT'),
- 'host': GetCodeReviewSetting('TRYSERVER_HTTP_HOST'),
- 'svn_repo': GetCodeReviewSetting('TRYSERVER_SVN_URL'),
- 'project': GetCodeReviewSetting('TRYSERVER_PROJECT'),
- 'root': GetCodeReviewSetting('TRYSERVER_ROOT'),
- 'patchlevel': GetCodeReviewSetting('TRYSERVER_PATCHLEVEL'),
- }
- for (k, v) in settings.iteritems():
- if v:
- trychange_args.extend(['--' + k, v])
-
- gclient_root = gclient_utils.FindGclientRoot(GetRepositoryRoot())
- if gclient_root:
- trychange_args.extend(['--root',
- gclient_utils.PathDifference(gclient_root,
- GetRepositoryRoot())])
if change_info:
trychange_args.extend(['--name', change_info.name])
if change_info.issue:
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | gclient_utils.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698