Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 5162006: Always send the device ID when making device management requests. (Closed)

Created:
10 years, 1 month ago by Mattias Nissler (ping if slow)
Modified:
9 years, 7 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org, danno, gfeher, Jakob Kummerow (corp)
Visibility:
Public.

Description

Always send the device ID when making device management requests. While at it, clean up use of policy constants. BUG=62060 TEST=Compiles and passes existing tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -93 lines) Patch
M chrome/browser/policy/device_management_backend.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_management_backend_impl.h View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_management_backend_impl.cc View 11 chunks +56 lines, -33 lines 0 comments Download
M chrome/browser/policy/device_management_policy_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/device_management_policy_provider_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/device_management_service_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/policy/device_management_service_unittest.cc View 14 chunks +64 lines, -46 lines 0 comments Download
M chrome/browser/policy/mock_device_management_backend.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/policy/mock_device_management_backend.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M net/tools/testserver/device_management.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mattias Nissler (ping if slow)
Please review.
10 years, 1 month ago (2010-11-19 18:35:33 UTC) #1
markusheintz_
10 years, 1 month ago (2010-11-22 10:33:21 UTC) #2
LGTM

On 2010/11/19 18:35:33, Mattias Nissler wrote:
> Please review.

Powered by Google App Engine
This is Rietveld 408576698