chrome/browser/policy/device_management_policy_provider_unittest.cc - Issue 5162006: Always send the device ID when making device management requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/device_management_policy_provider_unittest.cc

Issue 5162006: Always send the device ID when making device management requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/device_management_policy_provider.cc ('k') | chrome/browser/policy/device_management_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/device_management_policy_provider_unittest.cc

diff --git a/chrome/browser/policy/device_management_policy_provider_unittest.cc b/chrome/browser/policy/device_management_policy_provider_unittest.cc

index bd27e48683303cf27c7586b1e473ab355384f0af..57172869e4fe0dc8f7bffea3fe5b0bf05b1f9c05 100644

--- a/chrome/browser/policy/device_management_policy_provider_unittest.cc

+++ b/chrome/browser/policy/device_management_policy_provider_unittest.cc

@@ -63,7 +63,7 @@ class DeviceManagementPolicyProviderTest : public testing::Test {

MockConfigurationPolicyStore store;

backend_->AllShouldSucceed();

EXPECT_CALL(*backend_, ProcessRegisterRequest(_, _, _, _)).Times(1);

- EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _)).Times(1);

+ EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _, _)).Times(1);

SimulateSuccessfulLoginAndRunPending();

EXPECT_CALL(store, Apply(kPolicyDisableSpdy, _)).Times(1);

provider_->Provide(&store);

@@ -113,7 +113,7 @@ TEST_F(DeviceManagementPolicyProviderTest, EmptyProvideWithFailedBackend) {

MockConfigurationPolicyStore store;

backend_->AllShouldFail();

EXPECT_CALL(*backend_, ProcessRegisterRequest(_, _, _, _)).Times(1);

- EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _)).Times(0);

+ EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _, _)).Times(0);

SimulateSuccessfulLoginAndRunPending();

EXPECT_CALL(store, Apply(kPolicyDisableSpdy, _)).Times(0);

provider_->Provide(&store);

@@ -129,7 +129,7 @@ TEST_F(DeviceManagementPolicyProviderTest, SecondProvide) {

// Simulate a app relaunch by constructing a new provider. Policy should be

// immediately provided and no refresh should be triggered.

CreateNewBackend();

- EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _)).Times(0);

+ EXPECT_CALL(*backend_, ProcessPolicyRequest(_, _, _, _)).Times(0);

CreateNewProvider();

MockConfigurationPolicyStore store;

EXPECT_CALL(store, Apply(kPolicyDisableSpdy, _)).Times(1);