Changes needed to compile command-buffer code with nacl gcc. This CL just add...

Changes needed to compile command-buffer code with nacl gcc. This CL just adds unhandled enums in switch statements.

BUG=26104
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35485

[apatrick, 2009-12-29 20:26:37]

LGTM

http://codereview.chromium.org/515051/diff/1/2
File command_buffer/common/resource.cc (right):

http://codereview.chromium.org/515051/diff/1/2#newcode26
command_buffer/common/resource.cc:26: case kUnknown:
It's strange that NaCl's gcc needs this. Have you let the NaCl team know? It
seems like a bug.

[alokp, 2009-12-29 20:51:45]

http://codereview.chromium.org/515051/diff/1/2
File command_buffer/common/resource.cc (right):

http://codereview.chromium.org/515051/diff/1/2#newcode26
command_buffer/common/resource.cc:26: case kUnknown:
NaCl compile environment is really strict. They use all kinds of flags to treat
warnings as errors. I will add Nicholas and David Sehr to this CL so that they
are aware.

[alokp, 2010-01-04 21:46:45]

Nicholas/David: Do you expect to handle each case in switch statement? If yes, I
will go ahead and submit this CL.

[sehr (please use chromium), 2010-01-04 21:54:09]

All the code in NaCl builds with switch-enum, so yes, you would need to do
this.

David

On Mon, Jan 4, 2010 at 1:46 PM, <alokp@chromium.org> wrote:

> Nicholas/David: Do you expect to handle each case in switch statement? If
> yes, I
> will go ahead and submit this CL.
>
>
> http://codereview.chromium.org/515051
>