Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 515045: Apply -lgcov link to type loadable_bundle when building coverage=1. (Closed)

Created:
10 years, 12 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Apply -lgcov link to type loadable_bundle when building coverage=1. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
John Grabowski
Note: I reversed logic because _type=="loadable_module" never seemed to to be true even when it ...
10 years, 12 months ago (2009-12-28 20:38:35 UTC) #1
bradn
10 years, 12 months ago (2009-12-28 20:41:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698