Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: build/common.gypi

Issue 515045: Apply -lgcov link to type loadable_bundle when building coverage=1. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files should set chromium_code to 1 if they build Chromium-specific 10 # .gyp files should set chromium_code to 1 if they build Chromium-specific
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 'ENABLE_GPU=1', 354 'ENABLE_GPU=1',
355 ], 355 ],
356 }], 356 }],
357 ['coverage!=0', { 357 ['coverage!=0', {
358 'conditions': [ 358 'conditions': [
359 ['OS=="mac"', { 359 ['OS=="mac"', {
360 'xcode_settings': { 360 'xcode_settings': {
361 'GCC_INSTRUMENT_PROGRAM_FLOW_ARCS': 'YES', # -fprofile-arcs 361 'GCC_INSTRUMENT_PROGRAM_FLOW_ARCS': 'YES', # -fprofile-arcs
362 'GCC_GENERATE_TEST_COVERAGE_FILES': 'YES', # -ftest-coverage 362 'GCC_GENERATE_TEST_COVERAGE_FILES': 'YES', # -ftest-coverage
363 }, 363 },
364 # Add -lgcov for executables and shared_libraries, not for 364 # Add -lgcov for types executable, shared_library, and
365 # static_libraries. This is a delayed conditional. 365 # loadable_module; not for static_library.
366 # This is a delayed conditional.
366 'target_conditions': [ 367 'target_conditions': [
367 ['_type=="executable" or _type=="shared_library"', { 368 ['_type!="static_library"', {
368 'xcode_settings': { 'OTHER_LDFLAGS': [ '-lgcov' ] }, 369 'xcode_settings': { 'OTHER_LDFLAGS': [ '-lgcov' ] },
369 }], 370 }],
370 ], 371 ],
371 }], 372 }],
372 # Linux gyp (into scons) doesn't like target_conditions? 373 # Linux gyp (into scons) doesn't like target_conditions?
373 # TODO(???): track down why 'target_conditions' doesn't work 374 # TODO(???): track down why 'target_conditions' doesn't work
374 # on Linux gyp into scons like it does on Mac gyp into xcodeproj. 375 # on Linux gyp into scons like it does on Mac gyp into xcodeproj.
375 ['OS=="linux"', { 376 ['OS=="linux"', {
376 'cflags': [ '-ftest-coverage', 377 'cflags': [ '-ftest-coverage',
377 '-fprofile-arcs' ], 378 '-fprofile-arcs' ],
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 # and therefore SYMROOT, needs to be set at the project level. 1141 # and therefore SYMROOT, needs to be set at the project level.
1141 'SYMROOT': '<(DEPTH)/xcodebuild', 1142 'SYMROOT': '<(DEPTH)/xcodebuild',
1142 }, 1143 },
1143 } 1144 }
1144 1145
1145 # Local Variables: 1146 # Local Variables:
1146 # tab-width:2 1147 # tab-width:2
1147 # indent-tabs-mode:nil 1148 # indent-tabs-mode:nil
1148 # End: 1149 # End:
1149 # vim: set expandtab tabstop=2 shiftwidth=2: 1150 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698