Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 5133001: Shuffle things on the GPU layout test bots so that we store results... (Closed)

Created:
10 years, 1 month ago by Dirk Pranke
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Shuffle things on the GPU layout test bots so that we store results as if the builders were called "$X - GPU" instead of "$X", and put the results in "/layout-test-results/$X - GPU" instead of /layout-test-results.gpu/$X . BUG=none R=ojan@chromium.org TEST=manually verify files are going into the right places Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69890

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M scripts/master/factory/chromium_commands.py View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dirk Pranke
Hmm. I thought I had landed this weeks ago. Maybe I never sent it out ...
10 years ago (2010-12-15 19:55:51 UTC) #1
M-A Ruel
And rietveld tells us you indeed didn't send an email. :) http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): ...
10 years ago (2010-12-15 20:00:12 UTC) #2
Dirk Pranke
http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium_commands.py#newcode629 scripts/master/factory/chromium_commands.py:629: '--builder-name', builder_name,] On 2010/12/15 20:00:12, Marc-Antoine Ruel wrote: > ...
10 years ago (2010-12-15 20:41:19 UTC) #3
M-A Ruel
http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium_commands.py#newcode629 scripts/master/factory/chromium_commands.py:629: '--builder-name', builder_name,] On 2010/12/15 20:41:19, dpranke wrote: > On ...
10 years ago (2010-12-15 21:17:01 UTC) #4
Dirk Pranke
Oh, I see. Yes, I'll do that. On Wed, Dec 15, 2010 at 1:17 PM, ...
10 years ago (2010-12-15 21:51:47 UTC) #5
Dirk Pranke
Okay. Take another look to make sure I followed you?
10 years ago (2010-12-15 23:31:58 UTC) #6
M-A Ruel
lgtm
10 years ago (2010-12-16 02:42:32 UTC) #7
nsylvain
10 years ago (2010-12-16 19:58:38 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698