Shuffle things on the GPU layout test bots so that we store results...

Shuffle things on the GPU layout test bots so that we store results
as if the builders were called "$X - GPU" instead of "$X", and put
the results in "/layout-test-results/$X - GPU" instead of
/layout-test-results.gpu/$X .

    BUG=none
    R=ojan@chromium.org
    TEST=manually verify files are going into the right places


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69890

[Dirk Pranke, 2010-12-15 19:55:51]

Hmm. I thought I had landed this weeks ago. Maybe I never sent it out for
review? Can someone take a look?

[M-A Ruel, 2010-12-15 20:00:12]

And rietveld tells us you indeed didn't send an email. :)

http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
File scripts/master/factory/chromium_commands.py (right):

http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
scripts/master/factory/chromium_commands.py:629: '--builder-name',
builder_name,]
I'd prefer to keep WithProperties() and just rename your builder_name to postfix
and set it to ' - GPU' or ''.

[Dirk Pranke, 2010-12-15 20:41:19]

http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
File scripts/master/factory/chromium_commands.py (right):

http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
scripts/master/factory/chromium_commands.py:629: '--builder-name',
builder_name,]
On 2010/12/15 20:00:12, Marc-Antoine Ruel wrote:
> I'd prefer to keep WithProperties() and just rename your builder_name to
postfix
> and set it to ' - GPU' or ''.

The problem here is that we're attempting to leverage the partition-by-builder
logic in Ojan's dashboards to separate out the GPU results from the non-GPU
results, but actually running this twice on a single builder.

So, assuming I understand your suggestion, I can't make your change because the
builder name won't be different between the two invocations.

I could add another argument to run-webkit-tests if you (understandably) don't
want to fudge the builder name won't actually be different in between the two
invocations (e.g., --dashboard-name). Right now there is code in
run-webkit-tests to hack around this, and I'm attempting to push the hack up a
layer so that run-webkit-tests itself doesn't need to know about this split.

[M-A Ruel, 2010-12-15 21:17:01]

http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
File scripts/master/factory/chromium_commands.py (right):

http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
scripts/master/factory/chromium_commands.py:629: '--builder-name',
builder_name,]
On 2010/12/15 20:41:19, dpranke wrote:
> On 2010/12/15 20:00:12, Marc-Antoine Ruel wrote:
> > I'd prefer to keep WithProperties() and just rename your builder_name to
> postfix
> > and set it to ' - GPU' or ''.
> 
> The problem here is that we're attempting to leverage the partition-by-builder
> logic in Ojan's dashboards to separate out the GPU results from the non-GPU
> results, but actually running this twice on a single builder.
> 
> So, assuming I understand your suggestion, I can't make your change because
the
> builder name won't be different between the two invocations.
> 
> I could add another argument to run-webkit-tests if you (understandably) don't
> want to fudge the builder name won't actually be different in between the two
> invocations (e.g., --dashboard-name). Right now there is code in
> run-webkit-tests to hack around this, and I'm attempting to push the hack up a
> layer so that run-webkit-tests itself doesn't need to know about this split.

Let me explain more clearly;

1) Assume you removed all the changes except line 621.
2) line 604:  builder_name = '%(buildername)s'
3) line 612:  builder_name += ' - GPU'
4) line 629: '--builder-name', WithProperties(builder_name),]

I hope it's clearer.

[Dirk Pranke, 2010-12-15 21:51:47]

Oh, I see. Yes, I'll do that.

On Wed, Dec 15, 2010 at 1:17 PM,  <maruel@chromium.org> wrote:
>
>
http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
> File scripts/master/factory/chromium_commands.py (right):
>
>
http://codereview.chromium.org/5133001/diff/1/scripts/master/factory/chromium...
> scripts/master/factory/chromium_commands.py:629: '--builder-name',
> builder_name,]
> On 2010/12/15 20:41:19, dpranke wrote:
>>
>> On 2010/12/15 20:00:12, Marc-Antoine Ruel wrote:
>> > I'd prefer to keep WithProperties() and just rename your
>
> builder_name to
>>
>> postfix
>> > and set it to ' - GPU' or ''.
>
>> The problem here is that we're attempting to leverage the
>
> partition-by-builder
>>
>> logic in Ojan's dashboards to separate out the GPU results from the
>
> non-GPU
>>
>> results, but actually running this twice on a single builder.
>
>> So, assuming I understand your suggestion, I can't make your change
>
> because the
>>
>> builder name won't be different between the two invocations.
>
>> I could add another argument to run-webkit-tests if you
>
> (understandably) don't
>>
>> want to fudge the builder name won't actually be different in between
>
> the two
>>
>> invocations (e.g., --dashboard-name). Right now there is code in
>> run-webkit-tests to hack around this, and I'm attempting to push the
>
> hack up a
>>
>> layer so that run-webkit-tests itself doesn't need to know about this
>
> split.
>
> Let me explain more clearly;
>
> 1) Assume you removed all the changes except line 621.
> 2) line 604:  builder_name = '%(buildername)s'
> 3) line 612:  builder_name += ' - GPU'
> 4) line 629: '--builder-name', WithProperties(builder_name),]
>
> I hope it's clearer.
>
> http://codereview.chromium.org/5133001/
>

[Dirk Pranke, 2010-12-15 23:31:58]

Okay. Take another look to make sure I followed you?

[M-A Ruel, 2010-12-16 02:42:32]

lgtm

[nsylvain, 2010-12-16 19:58:38]

LGTM