chrome/browser/resources/safe_browsing_malware_block.html - Issue 5102001: Add a checkbox to the malware interstitial page, for user to opt-in to send m...

Unified Diff: chrome/browser/resources/safe_browsing_malware_block.html

Issue 5102001: Add a checkbox to the malware interstitial page, for user to opt-in to send m... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.h » ('j') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/safe_browsing_malware_block.html

===================================================================

--- chrome/browser/resources/safe_browsing_malware_block.html (revision 66339)

+++ chrome/browser/resources/safe_browsing_malware_block.html (working copy)

@@ -201,8 +201,17 @@

moreButton.style.display = 'inline'

lessButton.style.display = 'none'

}

+ }

+ function savepreference() {

+ var checkBox = document.getElementById('checky')

+ if (checkBox.checked) {

+ sendCommand('doReport')

+ } else {

+ sendCommand('dontReport')

+ }

}

</script>

</head>

@@ -227,6 +236,13 @@

+ <div class="main">

panayiotis 2010/11/18 19:50:32 We should not show this div if we are in incognito

kewang 2010/11/20 00:45:51 added jsdisplay for a control here.

+ <hr>

+ <form class="submission">

+ <input name="checky" id="checky" type="checkbox" jsvalues=".checked:boxchecked" onclick="savepreference()"> <label for="checky" i18n-content="confirm_text"></label>

lzheng 2010/11/19 18:50:47 'checky' sounds a little strange. Do you mean 'che

kewang 2010/11/20 00:45:51 changed the name to 'checked' for name, and 'check

+ </form>

+ </div>

</div>

</td>

</table>