chrome/browser/resources/safe_browsing_malware_block.html - Issue 5102001: Add a checkbox to the malware interstitial page, for user to opt-in to send m...

Side by Side Diff: chrome/browser/resources/safe_browsing_malware_block.html

Issue 5102001: Add a checkbox to the malware interstitial page, for user to opt-in to send m... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.h » ('j') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html id="template_root" i18n-values="dir:textdirection">	2 <html id="template_root" i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <title i18n-content="title"></title>	4 <title i18n-content="title"></title>

5 <style>	5 <style>

6 body {	6 body {

7 background-color:#500;	7 background-color:#500;

8 font-family:Helvetica,Arial,sans-serif;	8 font-family:Helvetica,Arial,sans-serif;

9 margin:0px;	9 margin:0px;

10 }	10 }

(...skipping 183 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
194 var content = document.getElementById('detailinfo')	194 var content = document.getElementById('detailinfo')

195 if (content.style.display == 'none'){	195 if (content.style.display == 'none'){

196 content.style.display = 'block'	196 content.style.display = 'block'

197 moreButton.style.display = 'none'	197 moreButton.style.display = 'none'

198 lessButton.style.display = 'inline'	198 lessButton.style.display = 'inline'

199 } else {	199 } else {

200 content.style.display = 'none'	200 content.style.display = 'none'

201 moreButton.style.display = 'inline'	201 moreButton.style.display = 'inline'

202 lessButton.style.display = 'none'	202 lessButton.style.display = 'none'

203 }	203 }

	204 }

204	205

	206 function savepreference() {

	207 var checkBox = document.getElementById('checky')

	208 if (checkBox.checked) {

	209 sendCommand('doReport')

	210 } else {

	211 sendCommand('dontReport')

	212 }

205 }	213 }

	214

206 </script>	215 </script>

207 </head>	216 </head>

208 <body oncontextmenu="return false;">	217 <body oncontextmenu="return false;">

209 <div class="background"><img src="../security/resources/ssl_roadblock_background .png" width="100%" height="100%" alt="background" onmousedown="return false;"/>< /div>	218 <div class="background"><img src="../security/resources/ssl_roadblock_background .png" width="100%" height="100%" alt="background" onmousedown="return false;"/>< /div>

210 <table width="100%" cellspacing="0" cellpadding="0">	219 <table width="100%" cellspacing="0" cellpadding="0">

211 <td class="cell" valign="middle" align="center">	220 <td class="cell" valign="middle" align="center">

212 <div class="box">	221 <div class="box">

213 <div class="icon"><img src="shared/images/phishing_icon.png" alt="Malware Icon" onmousedown="return false;"/></div>	222 <div class="icon"><img src="shared/images/phishing_icon.png" alt="Malware Icon" onmousedown="return false;"/></div>

214 <div class="title" i18n-content="headLine"></div>	223 <div class="title" i18n-content="headLine"></div>

215 <div class="main" i18n-values=".innerHTML:description1" style="margin-bott om:15px"></div>	224 <div class="main" i18n-values=".innerHTML:description1" style="margin-bott om:15px"></div>

216 <div class="main" i18n-values=".innerHTML:description2"></div>	225 <div class="main" i18n-values=".innerHTML:description2"></div>

217	226

218 <div class="main">	227 <div class="main">

219 <form class="submission">	228 <form class="submission">

220 <input type="button" class="nicebutton" id="back" i18n-values="value:b ack_button" onclick="sendCommand('takeMeBack')">	229 <input type="button" class="nicebutton" id="back" i18n-values="value:b ack_button" onclick="sendCommand('takeMeBack')">

221 <input type="button" class="nicebutton" id="more" i18n-values="value:m ore_info_button" onclick="toggle()">	230 <input type="button" class="nicebutton" id="more" i18n-values="value:m ore_info_button" onclick="toggle()">

222 <input type="button" class="nicebutton" id="less" i18n-values="value:l ess_info_button" style="display:none" onclick="toggle()">	231 <input type="button" class="nicebutton" id="less" i18n-values="value:l ess_info_button" style="display:none" onclick="toggle()">

223 <br />	232 <br />

224 </form>	233 </form>

225 <span i18n-values=".innerHTML:description5" id="detailinfo" style="displ ay:none"></span>	234 <span i18n-values=".innerHTML:description5" id="detailinfo" style="displ ay:none"></span>

226 </div>	235 </div>

227	236

228 <div class="main" i18n-values=".innerHTML:description3" style="margin-top: 10px"></div>	237 <div class="main" i18n-values=".innerHTML:description3" style="margin-top: 10px"></div>

229	238

	239 <div class="main">
	panayiotis 2010/11/18 19:50:32 We should not show this div if we are in incognito We should not show this div if we are in incognito mode, or if the tab's url is https, since we are not going to send reports in this case anyway. kewang 2010/11/20 00:45:51 added jsdisplay for a control here. Show quoted text On 2010/11/18 19:50:32, panayiotis wrote: > We should not show this div if we are in incognito mode, or if the tab's url is > https, since we are not going to send reports in this case anyway. added jsdisplay for a control here.
	240 <hr>

	241 <form class="submission">

	242 <input name="checky" id="checky" type="checkbox" jsvalues=".checked:bo xchecked" onclick="savepreference()"> <label for="checky" i18n-content="con firm_text"></label>
	lzheng 2010/11/19 18:50:47 'checky' sounds a little strange. Do you mean 'che 'checky' sounds a little strange. Do you mean 'check_yes', or 'checked'? If user checked this box, what will we show the next time user get into this page? Will the checkbox be checked? I am not clear how the jsvalues=".checked:boxchecked" related to the boxchecked in safe_browsing_blocking_page.cc. kewang 2010/11/20 00:45:51 changed the name to 'checked' for name, and 'check Show quoted text On 2010/11/19 18:50:47, lzheng wrote: > 'checky' sounds a little strange. Do you mean 'check_yes', or 'checked'? changed the name to 'checked' for name, and 'checkreport' for id name. Show quoted text > > If user checked this box, what will we show the next time user get into this > page? Will the checkbox be checked? I am not clear how the > jsvalues=".checked:boxchecked" related to the boxchecked in > safe_browsing_blocking_page.cc. Yes, works as you described. If the user checked it, all the following opened tabs or new browser after exit will have it checked automatically.
	243 </form>

	244 </div>

	245

230 </div>	246 </div>

231 </td>	247 </td>

232 </table>	248 </table>

233 </body>	249 </body>

234 </html>	250 </html>

OLD	NEW