Issue 5097001: Support AXContents attribute on the RenderWidgetHostViewCocoa....

Issue 5097001: Support AXContents attribute on the RenderWidgetHostViewCocoa.... (Closed)

Created:
10 years, 1 month ago by David Tseng

Modified:
9 years, 5 months ago

Reviewers:
Chris Guillory

CC:
dmazzoni, chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support AXContents attribute on the RenderWidgetHostViewCocoa. BUG=none. TEST=none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66382

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

Couple comments. Otherwise LGTM. http://codereview.chromium.org/5097001/diff/1/chrome/browser/renderer_host/render_widget_host_view_mac.mm File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right): http://codereview.chromium.org/5097001/diff/1/chrome/browser/renderer_host/render_widget_host_view_mac.mm#newcode1791 chrome/browser/renderer_host/render_widget_host_view_mac.mm:1791: [attribute isEqualToString:NSAccessibilityContentsAttribute]) && Seems like ...

10 years, 1 month ago (2010-11-16 22:37:10 UTC) #2

David Tseng

10 years, 1 month ago (2010-11-16 23:46:23 UTC) #3

get_host_view_mac.mm#newcode1791
> chrome/browser/renderer_host/render_widget_host_view_mac.mm:1791:
> [attribute isEqualToString:NSAccessibilityContentsAttribute]) &&
> Seems like it should be more clear that children and contents aren't the
> same. Can we add a comment specifying that the contents of a render
> widget host view cocoa element is the document view provided by the
> browser accessibility manager?
>
done.

>
http://codereview.chromium.org/5097001/diff/1/chrome/browser/renderer_host/re...
> chrome/browser/renderer_host/render_widget_host_view_mac.mm:1805: [ret
> addObjectsFromArray:[super accessibilityAttributeNames]];
> Nit: Should we check/dcheck that NSAccessibilityContentsAttribute isn't
> added a second time here?
>

This isn't necessary since BaseView<...> which we inherit from, is a
descendant of NSView which does not specify
NSAccessibilityContentAttribute in its accessibilityAttributeNames.

Expand Messages | Collapse Messages