Support AXContents attribute on the RenderWidgetHostViewCocoa....

chrome/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "chrome/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include "app/app_switches.h"
 #include "app/surface/io_surface_support_mac.h"
@@ skipping 1769 matching lines @@
 }
 
 - (NSUInteger)accessibilityArrayAttributeCount:(NSString *)attribute {
   NSArray* fullArray = [self accessibilityAttributeValue:attribute];
   return [fullArray count];
 }
 
 - (id)accessibilityAttributeValue:(NSString *)attribute {
   BrowserAccessibilityManager* manager =
       renderWidgetHostView_->browser_accessibility_manager_.get();
-  if ([attribute isEqualToString:NSAccessibilityChildrenAttribute] &&
+  if (([attribute isEqualToString:NSAccessibilityChildrenAttribute] ||
+          [attribute isEqualToString:NSAccessibilityContentsAttribute]) &&

[Chris Guillory, 2010/11/16 22:37:11]

Seems like it should be more clear that children and contents aren't the same.
Can we add a comment specifying that the contents of a render widget host view
cocoa element is the document view provided by the browser accessibility
manager?

       manager) {
     return [NSArray arrayWithObjects:manager->
         GetRoot()->toBrowserAccessibilityCocoa(), nil];
   } else if ([attribute isEqualToString:NSAccessibilityRoleAttribute]) {
     return NSAccessibilityScrollAreaRole;
   }
   id ret = [super accessibilityAttributeValue:attribute];
   return ret;
 }
 
+- (NSArray*)accessibilityAttributeNames {
+  NSMutableArray* ret = [[[NSMutableArray alloc] init] autorelease];
+  [ret addObject:NSAccessibilityContentsAttribute];
+  [ret addObjectsFromArray:[super accessibilityAttributeNames]];

[Chris Guillory, 2010/11/16 22:37:11]

Nit: Should we check/dcheck that NSAccessibilityContentsAttribute isn't added a
second time here?

+  return ret;
+}
+
 - (id)accessibilityHitTest:(NSPoint)point {
   if (!renderWidgetHostView_->browser_accessibility_manager_.get())
     return self;
   NSPoint pointInWindow = [[self window] convertScreenToBase:point];
   NSPoint localPoint = [self convertPoint:pointInWindow fromView:nil];
   localPoint.y = NSHeight([self bounds]) - localPoint.y;
   BrowserAccessibilityCocoa* root = renderWidgetHostView_->
       browser_accessibility_manager_->
           GetRoot()->toBrowserAccessibilityCocoa();
   id obj = [root accessibilityHitTest:localPoint];
@@ skipping 751 matching lines @@
   if (!string) return NO;
 
   // If the user is currently using an IME, confirm the IME input,
   // and then insert the text from the service, the same as TextEdit and Safari.
   [self confirmComposition];
   [self insertText:string];
   return YES;
 }
 
 @end