Issue 5094002: Fix favorite and auto_connect property usage (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5094002: Fix favorite and auto_connect property usage (again) (Closed)

Created:
10 years, 1 month ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
Charlie Lee

CC:
chromium-reviews, Paweł Hajdan Jr., arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix favorite and auto_connect property usage (again) The original CL was: http://codereview.chromium.org/4818002 which missed a unittest fix, and the commit(r66253) was reverted (r66258). Changed chrome/browser/chromeos/options/wifi_config_view_browsertest.cc and network_library.h. BUG=chromium-os:8193 TEST=manually open chrome://settings/internet and see if remembered networks are listed properly. For DOMUI network menu, pass --enable-domui-menu for chrome to enable and check. Also check browser_test --gtest_filter="WifiConfigViewTest.ChangeAutoConnectSaveTest" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66411

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -54 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1 2	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/internet_options_handler.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/network_menu_ui.cc	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/network_menu.js	View		7 chunks	+24 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_internet_detail.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_internet_options.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kochi

Hi Charlie, The original CL was reverted because I missed a change for browser_test. Now ...

10 years, 1 month ago (2010-11-17 08:48:54 UTC) #1

LGTM

Expand Messages | Collapse Messages

Issue 5094002: Fix favorite and auto_connect property usage (again) (Closed)

Description

Patch Set 1 #

Patch Set 2 : Sync with HEAD #

Patch Set 3 : Fix browsertest. #

Messages