Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: chrome/browser/chromeos/cros/network_library.h

Issue 5094002: Fix favorite and auto_connect property usage (again) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browsertest. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/cros/network_library.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library.h
diff --git a/chrome/browser/chromeos/cros/network_library.h b/chrome/browser/chromeos/cros/network_library.h
index fb80d09fcc14ecf9d177679efb18880a15d09c4a..9c49a1298257175731626321b3ca96bcd5d8e454 100644
--- a/chrome/browser/chromeos/cros/network_library.h
+++ b/chrome/browser/chromeos/cros/network_library.h
@@ -9,6 +9,7 @@
#include <string>
#include <vector>
+#include "base/gtest_prod_util.h"
#include "base/observer_list.h"
#include "base/platform_thread.h"
#include "base/singleton.h"
@@ -138,7 +139,9 @@ class WirelessNetwork : public Network {
bool favorite() const { return favorite_; }
void set_auto_connect(bool auto_connect) { auto_connect_ = auto_connect; }
- void set_favorite(bool favorite) { favorite_ = favorite; }
+ // We don't have a setter for |favorite_| because to unfavorite a network is
+ // equivalent to forget a network, so we call forget network on cros for
+ // that. See ForgetWifiNetwork().
// Network overrides.
virtual void Clear();
@@ -158,6 +161,9 @@ class WirelessNetwork : public Network {
bool favorite_;
private:
+ // ChangeAutoConnectSaveTest accesses |favorite_|.
+ FRIEND_TEST_ALL_PREFIXES(WifiConfigViewTest, ChangeAutoConnectSaveTest);
+
void set_name(const std::string& name) { name_ = name; }
void set_strength(int strength) { strength_ = strength; }
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/cros/network_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698