base/lock.h - Issue 5091005: FBTF: Remove unneeded headers from base/ (part 9)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/lock.h

Issue 5091005: FBTF: Remove unneeded headers from base/ (part 9) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/lock.h

===================================================================

--- base/lock.h (revision 66704)

+++ base/lock.h (working copy)

@@ -7,6 +7,9 @@

#pragma once

#include "base/lock_impl.h"

+#if !defined(NDEBUG)

+#include "base/platform_thread.h"

jar (doing other things) 2010/11/19 01:45:14 IMO, using conditional inclusion depending on debu

Lei Zhang 2010/11/19 19:06:16 I can definitely see this causing release vs. debu

+#endif

// A convenient wrapper for an OS specific critical section. The only real

// intelligence in this class is in debug mode for the support for the

« no previous file with comments | « base/file_util_posix.cc ('k') | base/lock_impl.h » ('j') | no next file with comments »