FBTF: Remove unneeded headers from base/ (part 9)

base/lock.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_LOCK_H_
 #define BASE_LOCK_H_
 #pragma once
 
 #include "base/lock_impl.h"
+#if !defined(NDEBUG)
+#include "base/platform_thread.h"

[jar (doing other things), 2010/11/19 01:45:14]

IMO, using conditional inclusion depending on debug is a bad choice.  I'd rather
see the includes and suffer the compile time than add such preprocessing ifs
like this.  

I'll be curious to hear Brett's perspective.

[Lei Zhang, 2010/11/19 19:06:16]

I can definitely see this causing release vs. debug build problems, so I removed
the #ifdef. All the bots except Windows passed on patch set 1, and Windows
passed on patch set 5.

+#endif
 
 // A convenient wrapper for an OS specific critical section.  The only real
 // intelligence in this class is in debug mode for the support for the
 // AssertAcquired() method.
 
 class Lock {
  public:
 #if defined(NDEBUG)             // Optimized wrapper implementation
   Lock() : lock_() {}
   ~Lock() {}
@@ skipping 97 matching lines @@
   ~AutoUnlock() {
     lock_.Acquire();
   }
 
  private:
   Lock& lock_;
   DISALLOW_COPY_AND_ASSIGN(AutoUnlock);
 };
 
 #endif  // BASE_LOCK_H_