Don't show "show in foloder" in chrome os.

Don't show "show in foloder" in chrome os.

BUG=chromiun-os:916
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34837

[sky, 2009-12-17 00:31:10]

http://codereview.chromium.org/506045/diff/1/2
File chrome/browser/dom_ui/downloads_ui.cc (right):

http://codereview.chromium.org/506045/diff/1/2#newcode88
chrome/browser/dom_ui/downloads_ui.cc:88: #if !defined(OS_CHROMEOS)
Use defaults for this like we talked about. From talking with folks on the team
it's the preferred way for conditionals like this.

[oshima, 2009-12-17 01:48:33]

done. it wasn't as bad as i thought (i missed !chromeos section)
can you review again?

On 2009/12/17 00:31:17, sky wrote:
>

[sky, 2009-12-17 16:18:26]

LGTM

http://codereview.chromium.org/506045/diff/1008/10
File chrome/browser/defaults.h (right):

http://codereview.chromium.org/506045/diff/1008/10#newcode59
chrome/browser/defaults.h:59: }  // namespace browser_defaults
newline between 58 and 59.

[Daniel Erat, 2009-12-17 16:23:38]

LGTM too.

http://codereview.chromium.org/506045/diff/1008/10
File chrome/browser/defaults.h (right):

http://codereview.chromium.org/506045/diff/1008/10#newcode57
chrome/browser/defaults.h:57: // Does the download page have the show in folder
option.
make this end with a '?' instead of '.' to match other comments in this file

[oshima, 2009-12-17 17:26:29]

submitting

http://codereview.chromium.org/506045/diff/1008/10
File chrome/browser/defaults.h (right):

http://codereview.chromium.org/506045/diff/1008/10#newcode57
chrome/browser/defaults.h:57: // Does the download page have the show in folder
option.
On 2009/12/17 16:23:38, Daniel Erat wrote:
> make this end with a '?' instead of '.' to match other comments in this file

Done.

http://codereview.chromium.org/506045/diff/1008/10#newcode59
chrome/browser/defaults.h:59: }  // namespace browser_defaults
On 2009/12/17 16:18:26, sky wrote:
> newline between 58 and 59.

Done.