Issue 505056: Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505056: Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory ... (Closed)

Created:
11 years ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Paul Godavari, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory measurements on OS X. Right now, this only works for the current process; support for child processes will be added in a later CL. BUG=13156, 25454 TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes. Review URL: http://codereview.chromium.org/500118 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/504068 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35043

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+212 lines, -64 lines)			Patch
M	base/process_util.h	View	4 chunks	+32 lines, -0 lines	0 comments	Download
M	base/process_util_mac.mm	View	2 chunks	+118 lines, -7 lines	0 comments	Download
M	base/process_util_posix.cc	View	2 chunks	+20 lines, -47 lines	0 comments	Download
M	base/trace_event.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager.cc	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/common/mach_ipc_mac.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/mach_ipc_mac.mm	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/test/chrome_process_util.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages