Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/task_manager.cc

Issue 505056: Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('k') | chrome/common/mach_ipc_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager.cc
===================================================================
--- chrome/browser/task_manager.cc (revision 35042)
+++ chrome/browser/task_manager.cc (working copy)
@@ -533,7 +533,14 @@
// Create the ProcessMetrics for this process if needed (not in map).
if (metrics_map_.find(process) == metrics_map_.end()) {
base::ProcessMetrics* pm =
+#if !defined(OS_MACOSX)
base::ProcessMetrics::CreateProcessMetrics(process);
+#else
+ // TODO(thakis): Write a port provider that knows the task ports of
+ // child processes.
+ base::ProcessMetrics::CreateProcessMetrics(process, NULL);
+#endif
+
metrics_map_[process] = pm;
}
@@ -770,12 +777,12 @@
}
void TaskManagerModel::OnJobDone(URLRequestJob* job,
- const URLRequestStatus& status) {
+ const URLRequestStatus& status) {
}
void TaskManagerModel::OnJobRedirect(URLRequestJob* job,
- const GURL& location,
- int status_code) {
+ const GURL& location,
+ int status_code) {
}
void TaskManagerModel::OnBytesRead(URLRequestJob* job, int byte_count) {
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('k') | chrome/common/mach_ipc_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698