gclient: Add better error reporting when path is not a git repo.

gclient: Add better error reporting when path is not a git repo.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36172

[djmm, 2009-12-15 18:49:56]

lgtm

On Tue, Dec 15, 2009 at 10:35 AM, <msb@chromium.org> wrote:

> Reviewers: Marc-Antoine Ruel, djmm,
>
> Description:
> gclient: Add better error reporting when path is not a git repo.
>
> Please review this at http://codereview.chromium.org/505007
>
> Affected files:
>  M gclient_scm.py
>
>
> Index: gclient_scm.py
> diff --git a/gclient_scm.py b/gclient_scm.py
> index
>
25b652410423a2a4ea7066f2efe228894069496b..cb888c5819f5bad02e3b570d351625b17aaec18a
> 100644
> --- a/gclient_scm.py
> +++ b/gclient_scm.py
> @@ -133,6 +133,14 @@ class GitWrapper(SCMWrapper, scm.GIT):
>       file_list.extend([os.path.join(self.checkout_path, f) for f in
> files])
>       return
>
> +    if not os.path.exists(os.path.join(self.checkout_path, '.git')):
> +      raise gclient_utils.Error('\n____ %s%s\n'
> +                                '\tPath is not a git repo. No .git dir.\n'
> +                                '\tTo resolve:\n'
> +                                '\t\trm -rf %s\n'
> +                                '\tAnd run gclient sync again\n'
> +                                % (self.relpath, rev_str, self.relpath))
> +
>     new_base = 'origin'
>     if revision:
>       new_base = revision
>
>
>

[M-A Ruel, 2009-12-15 18:58:08]

lgtm

would have been awesome with a test. :P

[Mandeep Singh Baines, 2010-01-13 21:26:13]

On 2009/12/15 18:58:08, Marc-Antoine Ruel wrote:
> lgtm
> 
> would have been awesome with a test. :P

Test added and code submitted.