Issue 504085: Add --sup_rep support to trychange.py.

Issue 504085: Add --sup_rep support to trychange.py. (Closed)

Created:
11 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add --sup_rep support to trychange.py. This adds the functionality to try a job spread across multiple checkouts. TEST=fixed unit tests and tested with hybrid svn-git checkouts BUG=none

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -55 lines)			Patch
M	scm.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/gcl_unittest.py	View	2 chunks	+7 lines, -14 lines	1 comment	Download
M	tests/scm_unittest.py	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/trychange_unittest.py	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	trychange.py	View	8 chunks	+50 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM, other than two questions. http://codereview.chromium.org/504085/diff/1/3 File tests/gcl_unittest.py (right): http://codereview.chromium.org/504085/diff/1/3#newcode73 tests/gcl_unittest.py:73: gcl.SVN.GetCheckoutRoot(root_path).AndReturn(root_path + '.~') Shouldn't ...

11 years ago (2009-12-22 20:38:47 UTC) #2

M-A Ruel

On 2009/12/22 20:38:47, bradn wrote: > LGTM, other than two questions. > > http://codereview.chromium.org/504085/diff/1/3 > ...

11 years ago (2009-12-22 20:45:39 UTC) #3

bradn

11 years ago (2009-12-22 20:53:03 UTC) #4

LGTM

On Tue, Dec 22, 2009 at 12:45 PM, <maruel@chromium.org> wrote:

> On 2009/12/22 20:38:47, bradn wrote:
>
>> LGTM, other than two questions.
>>
>
>  http://codereview.chromium.org/504085/diff/1/3
>> File tests/gcl_unittest.py (right):
>>
>
>  http://codereview.chromium.org/504085/diff/1/3#newcode73
>> tests/gcl_unittest.py:73:
>>
> gcl.SVN.GetCheckoutRoot(root_path).AndReturn(root_path
>
>> + '.~')
>> Shouldn't this be an os.path.join ?
>>
>
>  Why add the .~ ?
>>
>
> I'm mangling the path just to make sure it's using the right value.
>
>
> http://codereview.chromium.org/504085
>

Expand Messages | Collapse Messages