Issue 504059: First few accessibility tweaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504059: First few accessibility tweaks. (Closed)

Created:
11 years ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek, pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, feldstein1

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the tab strip and tabs first-class accessibility objects. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35091

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/tab_strip_view.mm	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
	M	chrome/browser/cocoa/tab_view.mm	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

10 years, 11 months ago (2010-01-04 14:54:32 UTC) #4

LGTM

On Mon, Dec 21, 2009 at 11:54 AM,  <rsesek@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/504059
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

Expand Messages | Collapse Messages