Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: net/http/http_auth_handler_factory.h

Issue 5034001: Remove static "set_fixed_cnonce" in favor of NonceGenerator objects.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Merge with trunk Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_handler_factory.h
===================================================================
--- net/http/http_auth_handler_factory.h (revision 66330)
+++ net/http/http_auth_handler_factory.h (working copy)
@@ -24,6 +24,8 @@
class HttpAuthHandlerRegistryFactory;
// An HttpAuthHandlerFactory is used to create HttpAuthHandler objects.
+// The HttpAuthHandlerFactory object _must_ outlive any of the HttpAuthHandler
eroman 2010/11/17 04:35:40 thanks for adding the comment.
+// objects that it creates.
class HttpAuthHandlerFactory {
public:
HttpAuthHandlerFactory() : url_security_manager_(NULL) {}
@@ -49,7 +51,7 @@
// challenge specified by |*challenge|. |challenge| must point to a valid
// non-NULL tokenizer.
//
- // If an HttpAuthHandler object is successfully created it is passed back to
+ // If an HttpAuthHandler object is successfully created it is passed back to
// the caller through |*handler| and OK is returned.
//
// If |*challenge| specifies an unsupported authentication scheme, |*handler|

Powered by Google App Engine
This is Rietveld 408576698