Remove static "set_fixed_cnonce" in favor of NonceGenerator objects....

net/http/http_auth_handler_factory.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_
 #define NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/scoped_ptr.h"
 #include "net/http/http_auth.h"
 #include "net/http/url_security_manager.h"
 
 class GURL;
 
 namespace net {
 
 class BoundNetLog;
 class HostResolver;
 class HttpAuthHandler;
 class HttpAuthHandlerRegistryFactory;
 
 // An HttpAuthHandlerFactory is used to create HttpAuthHandler objects.
+// The HttpAuthHandlerFactory object _must_ outlive any of the HttpAuthHandler

[eroman, 2010/11/17 04:35:40]

thanks for adding the comment.

+// objects that it creates.
 class HttpAuthHandlerFactory {
  public:
   HttpAuthHandlerFactory() : url_security_manager_(NULL) {}
   virtual ~HttpAuthHandlerFactory() {}
 
   // Sets an URL security manager.  HttpAuthHandlerFactory doesn't own the URL
   // security manager, and the URL security manager should outlive this object.
   void set_url_security_manager(URLSecurityManager* url_security_manager) {
     url_security_manager_ = url_security_manager;
   }
 
   // Retrieves the associated URL security manager.
   URLSecurityManager* url_security_manager() {
     return url_security_manager_;
   }
 
   enum CreateReason {
     CREATE_CHALLENGE,  // Create a handler in response to a challenge.
     CREATE_PREEMPTIVE,    // Create a handler preemptively.
   };
 
   // Creates an HttpAuthHandler object based on the authentication
   // challenge specified by |*challenge|. |challenge| must point to a valid
   // non-NULL tokenizer.
   //
-  // If an HttpAuthHandler object  is successfully created it is passed back to
+  // If an HttpAuthHandler object is successfully created it is passed back to
   // the caller through |*handler| and OK is returned.
   //
   // If |*challenge| specifies an unsupported authentication scheme, |*handler|
   // is set to NULL and ERR_UNSUPPORTED_AUTH_SCHEME is returned.
   //
   // If |*challenge| is improperly formed, |*handler| is set to NULL and
   // ERR_INVALID_RESPONSE is returned.
   //
   // |create_reason| indicates why the handler is being created. This is used
   // since NTLM and Negotiate schemes do not support preemptive creation.
@@ skipping 127 matching lines @@
  private:
   typedef std::map<std::string, HttpAuthHandlerFactory*> FactoryMap;
 
   FactoryMap factory_map_;
   DISALLOW_COPY_AND_ASSIGN(HttpAuthHandlerRegistryFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_