Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 502078: Remove trychange.RunCommand and replace it by gclient_utils.CheckCall. (Closed)

Created:
11 years ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove trychange.RunCommand and replace it by gclient_utils.CheckCall. TEST=unit tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -52 lines) Patch
M gclient_utils.py View 1 chunk +24 lines, -0 lines 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +49 lines, -0 lines 0 comments Download
M tests/trychange_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trychange.py View 5 chunks +45 lines, -50 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years ago (2009-12-18 20:46:49 UTC) #1
bradn
11 years ago (2009-12-18 21:10:28 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698