Remove trychange.RunCommand and replace it by gclient_utils.CheckCall.

tests/gclient_utils_test.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 import StringIO
 
 import gclient_utils
 from super_mox import SuperMoxTestBase
 
+
+class GclientUtilsUnittest(SuperMoxTestBase):
+  """General gclient_utils.py tests."""
+  def testMembersChanged(self):
+    members = [
+        'CheckCall', 'CheckCallError', 'Error', 'FileRead', 'FileWrite',
+        'FullUrlFromRelative', 'FullUrlFromRelative2', 'GetNamedNodeText',
+        'GetNodeNamedAttributeText', 'IsUsingGit', 'ParseXML',
+        'PrintableObject', 'RemoveDirectory', 'SplitUrlRevision',
+        'SubprocessCall', 'SubprocessCallAndFilter', 'errno', 'os', 're',
+        'stat', 'subprocess', 'sys', 'time', 'xml',
+    ]
+    # If this test fails, you should add the relevant test.
+    self.compareMembers(gclient_utils, members)
+
+
+class CheckCallTestCase(SuperMoxTestBase):
+  def testCheckCallSuccess(self):
+    command = ['boo', 'foo', 'bar']
+    process = self.mox.CreateMockAnything()
+    process.retcode = 0
+    gclient_utils.subprocess.Popen(
+        command, cwd=None,
+        stdout=gclient_utils.subprocess.PIPE,
+        shell=gclient_utils.sys.platform.startswith('win')).AndReturn(process)
+    process.communicate().AndReturn(['bleh'])
+    self.mox.ReplayAll()
+    gclient_utils.CheckCall(command)
+
+  def testCheckCallFailure(self):
+    command = ['boo', 'foo', 'bar']
+    process = self.mox.CreateMockAnything()
+    process.retcode = 42
+    gclient_utils.subprocess.Popen(
+        command, cwd=None,
+        stdout=gclient_utils.subprocess.PIPE,
+        shell=gclient_utils.sys.platform.startswith('win')).AndReturn(process)
+    process.communicate().AndReturn(['bleh'])
+    self.mox.ReplayAll()
+    try:
+      gclient_utils.CheckCall(command)
+      self.fail()
+    except gclient_utils.CheckCallError, e:
+      self.assertEqual(e.command, command)
+      self.assertEqual(e.cwd, None)
+      self.assertEqual(e.retcode, 42)
+      self.assertEqual(e.stdout, 'bleh')
+
+
 class SubprocessCallAndFilterTestCase(SuperMoxTestBase):
   def testSubprocessCallAndFilter(self):
     command = ['boo', 'foo', 'bar']
     in_directory = 'bleh'
     fail_status = None
     pattern = 'a(.*)b'
     test_string = 'ahah\naccb\nallo\naddb\n'
     class Mock(object):
       stdout = StringIO.StringIO(test_string)
       def wait(self):
@@ skipping 74 matching lines @@
     base_url = 'svn://a/b/c/d'
     full_url = gclient_utils.FullUrlFromRelative2(base_url, '/crap')
     self.assertEqual(full_url, 'svn://a/b/c/crap')
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()
 
 # vim: ts=2:sw=2:tw=80:et: